Add export_events route and controller action to export dummy CSV#204
Draft
YoshwanPathipati wants to merge 1 commit intoOpenDSA:stagingfrom
Draft
Add export_events route and controller action to export dummy CSV#204YoshwanPathipati wants to merge 1 commit intoOpenDSA:stagingfrom
YoshwanPathipati wants to merge 1 commit intoOpenDSA:stagingfrom
Conversation
awhicks
requested changes
Jul 16, 2025
Member
awhicks
left a comment
awhicks
left a comment
There was a problem hiding this comment.
Thank you for working on this! A couple of changes:
- Bring back the ODSA_BRANCH arg in the Dockerfile
- If possible, can you amend the commit to avoid pushing the file permission changes to all the script files, in particular, when you commit, make sure you git add only the files you intend to
- I think we'll probably hold off getting this merged until you've implemented the queries for the database in the course offerings controller
Hopefully all that makes sense?
YoshwanPathipati
force-pushed
the
staging
branch
from
07435c1 to
8e796b9
Compare
Author
|
Updated the commit with Dockerfile ARG and cleaned up permissions. Holding this as a draft until database query for export_events is implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
course_offeringsto export events.export_eventsmethod inCourseOfferingsController.rails routes, and renders fromhttps://opendsa-lti.localhost.devcom.vt.edu/course_offerings/2/export_eventsfind_attempts— looks unrelated to new code.